-
Notifications
You must be signed in to change notification settings - Fork 382
Conversation
this bug is caused by the time interval between two taps which is too small.
I don't really see this as a bug, works fine for me. Nevertheless Apple's default timeout for double tap in voiceover is 0.25 so maybe 0.25 is a good fit. |
thanks for the reply. |
@certainly sorry my response was a bit vague. Sent with GitHawk |
@certainly haha well then +1 for this PR. To be honest I never even knew this was an option until this PR. Anyways sorry for the mixup def would like it to work for everyone! Sent with GitHawk |
* Fix cell size on the Bookmarks tab (#2124) * Create code of conduct (#2126) It is encouraged by GitHub to comply with recommended community standards. * Fixed s/nuber/number/ typo in SECURITY.md (#2130) * Add issue template for feature request (#2132) Use GitHub template. * Add issue template for bug report (#2131) Use GitHub template. * bump version to 1.23 (#2143) * Replace "Inbox Zero" functionality and remove Firebase (#2142) * simpler inbox zero date that allows date planning * clean up * remove firebase * Don't override entire message when replying (#2160) * Local push notifications (#2145) * add fmdb * add local notification cache mechanism * rewiring to update local db when fetching notifications * local pushes working * building for xcode 10 * Add UIAppearance styling for UISwitch & UISearchBar (#2144) * Add(UIAppearance styling for UISwitch) * Add(UIAppearance for UISearchBar) * Added activity indicator (#2157) * Fixes bug where send button is enabled after sending a comment (#2158) * Load Consistency (#2159) * Combine 2 load cells into 1 * Fixed load more in BaseViewController * Switch if-else to ternary * adds review GitHubAccess button to notifications view controller (#2176) * Action Controller images (#2135) * Add images to action controller * Added pod to podfile Added icon to NotificationSectionController * Installed Pod * ContextMenu Dominant corner * Target support files * Fixed support * Updated Action Image Controller * grammatical change to code signing instructions (#2186) * Add TestFlight link to README (#2194) * Add TestFlight link to README * Update README.md * fix double tap tab invalid (#2192) this bug is caused by the time interval between two taps which is too small. * Fixed color issue. (#2188) * allows setting Milestone's loading indicator's color (#2195) * allows setting loading indicator's color * updated spinner color to .white in Milestones/Labels/People * Merge button status (#2189) * Addresses #2178 Shows merge status without button when you cannot merge. * Swift naming * Fortify local notifications code (#2191) * move path/defaults to be injected * remove unused defaults * add tests for notification db, fix settings, avoid dupe inbox requests * better tests, fix dupe insert bug * Attempt to fix iTunes Connect issue where watchOS needs min target (#2173) * attempt to fix iTunes Connect issue where watchOS needs min target * fix podfile * Use updatedAt time to key notification send times (#2201) * Use updatedAt time to key notification send times * better formatting and fix tests * Delete CNAME * move blog to own repo (#2205) * fixed icon name (#2203) * Move lock (#2206) * Moves lock under divider * fix param style * Update IssueManagingContextController.swift * Switched to constants (#2207) * move designs to own repo (#2208) * Delete appcenter-post-clone.sh * Delete AppStore.md * Restore readme images after assets move (#2210) * Move entitlements to Resources (#2209) * Fixed cell border on merge button (#2204) * Fixed cell border on merge button * Fixed nits * Settings cell textColor (#2193) * Set API Status cell textColor to custom (Matching the rest of the settings page) * Updated Double Tap Reaction off color to custom * Updated Enabled textColor to custom * Updated reaction textColors to proper custom * Switched all labels to settingsLabels * Fix entitlements path (#2211) * change repo branch (#2202) * change repo branch additions: - A change-repository-branch workflow thats very similar to the workflow in Milestones - GraphQL query to fetch a repo's branches modifications: - a mutable "branch" string in RepositoryOverviewController and RepositoryCodeDirectoryViewController - updated the V3RepositoryReadME fetch to include a branch parameter - a protocol RepositoryBranchUpdatable to flag and update the appropriate ViewControllers when a user switches branches - ContextMenu and UIAlertAction setup - Removed some outdated code to get a repo's branch name from fetch(page:) in RepositoryOverviewViewController - Added a line feed.adapter.reloadData() in fetch(page:) because app was crashing intermittently after a user switched branches without that line - was always an IGListKit duplicate identifier error on StyledTextRenderers - to reproduce, remove the feed.adapter.reloadData(), go to https://github.com/TheAlgorithms/Python, try to switch branches and the app will crash. I'm working raising an issue for it. * requested changes - changed public var to private(set) for var branch: String - removed wasteful feed.adapter.reloadData() call - re-formated params in switchBranchAction() * style nit * Localize Inbox Zero and allow for per-year holidays (#2215) * Update Setup.md (#2218) Grammatical change to md * set spinner color in RepoBranchVC (#2221) * Order repo branches after fetch (#2228) * Order repo branches after fetch - added func to order branches + unit tests - replaced 'var branch: String' w/ 'private(set) var selectedBranch: String' & added a defaultBranch variable - changed fetch(page:) to update(animated:) in didSelect(value:) - an oversight from original pr * AX animation * Fix readme duplicate identifier asserts (#2219) * WIP to fix readme asserts * remove newline * improved markdown parsing working * fix tests * Huge refactor of AppDelegate and authentication routing (#2238) * refactor with new app controller, replace root nav mgr * finish refactoring out root nav mgr * remove root mgr * Adds more share actions when browsing a repository (#2161) (#2237) * add additional share actions * fix share URLs * use edge inset to right align image (#2232) * new routing library and refactor shortcuts (#2241) * [FIX] Settings write review indent (#2242) * PeopleVC: Sort users with self first (#2246) - moves sorting logic from fetch(page:) into type method - unit test * Simpler logic for review access button handling (#2249) * Always update shortcuts on app launch (#2248) * move the bookmark icon for the RepoVC and address a CR comment (#2255) * always call completion block when early returning b/c of bg (#2258) * open issue from notification (#2259) * [FIX] Navigation for double tap reaction on settings (#2275) - Changes segue kind from show to showDetail - Adds a navigation controller for "Double tap Reaction" so it will work on both iPhone and iPad * [FIX] Navigation controller on "View Source" from settings (#2276) * keep read layer in front when animating inbox (#2280) * Proper fix to prevent double fetching from background (#2279) * Update Gemfile to use same version of CocoaPods referenced in Podfile.lock (#2277) * Update cocoapods version constraint * Run `bundle update cocoapods` * Run `npm install` * Add new iPhone models to UIDevice+Model.swift (#2278) * Switched from long press to tap recognizer for menu controllers (#2271) * Add steps in the setup to avoid commiting env variables to the repo (#2262) * Add "Try Again" button for EmptyView (#2214) (#2226) * Button to display Push Notification info in Settings (#2282) * Add push notification info in settings * better sizing * add empty error view to latest base VC (#2283) * move background handling into feed for better state control (#2285) * thread error descriptions to squawk throughout app (#2286) * Update MessageViewController (#2287) * update messageviewcontroller * add latest update * update with revert * Add clear button to action menus (#2288) * Add clear button to the labels and milestone action menu * Move the selection count in the PeopleViewController into the title Add a clear button to the people controller * Remove mock return for testing action menu * Add "Clear" string constant Remove unused Protocol * Setup the clear enabled state and the Poeple title correctly on init * Sorts issues after fetch (#2304) *reverse chronologically * Warn that logging out removes bookmarks (#2303) * Enable SwiftLint and fix issues (#2292) * update swiftlint * build with lint enabled * fix almost all warnings * remove wholemodule * fetch subscription status and fix mutation (#2291) * update ContextMenu (#2310) * reopen menu item is green (#2311) * fix landscape read animation issue (#2312) * Search for labels in app (take two) (#2314) * Created DidTap Protocol for label section controllers - created a protocol to route tap events to a delegate. The idea is that the delgate will have a reference to GithubClient and we can limit the baggage of passing around GithubClient * Refactor Repo VC and SC to use name and owner as parameters - Will make it easier to present RepoVC without needing a ref to RepositoryDetails. The only parameters being used from RepositoryDetails were owner and name * Added presentLabels extension to UIViewController * requested changes * Show PR CI status inline with title (#2325) * remove unused gql * show PR CI status in list * update StyledTextKit * Thread networking errors and add custom error descriptions (#2324) * Better network error descriptions * localized descriptions for custom errors * Improve empty retry UX (#2323) * Highlight CodeView text on a background queue (#2322) * Browse commit history of repositories, directories, and files (#2321) * add history request * Browse commit history of repo, directories, and files * Move routes to own pod (#2317) * Use https url for login (#2327) Removes a deprecation warning for SFAuthentication because of using http * Expand push settings info accessibility label (#2326) * cleans up issue labels query (#2334) * Move dropdown control to own lib (#2335) * Move dropdown control to own lib * update to add missing assets * fix interaction, set appearances * clear push notifications on open (#2336) * update dropdown view for centered title view (#2338) * inset preview collection view (#2340) * update routing lib and wire up new repo route (#2344) * Update reivewGitHUbAccessBtn constraints (#2339) * [ADD] "Try Beta" cell on Settings (#2346) Adds "Try Beta" cell on Settings screen, On tap opens the testflight invite link in safari * Message on "Try Beta" when already in TF (#2351) * [ADD] On Tap "Try Beta", show Squawk message when user is already on beta * Update Squawk+GitHawk.swift * Fixes regex for consecutive shortlinks (#2358) - updated unit tests * Fix typo in TF squawk (#2361) * Lowercase issue/PR search string (#2360) * fix lints * lowercase search string * fix more lints * Allow showing/cloning repository in Working Copy when installed (#2366) .../more button when looking at repository has extra action when Working Copy is installed to show or clone this repository in this app. * Fixes Reaction emoji updates on split view (#2359) * [FIX] Reaction emoji updates on split view * [FIX] Change listener to delegate * Update MessageViewController (#2370) * Update routes to final form (#2374) * update routes to final form * fix routes build and update with router object
this bug is caused by the time interval between two taps which is too small.